Skip to content

BWEM Bugfix: Different chokes considered equal - #104

Merged
JasperGeurtz merged 2 commits into
JavaBWAPI:developfrom
dgant:codex/chokepoint-identity-upstream
Nov 11, 2026
Merged

JasperGeurtz merged 2 commits into
JavaBWAPI:developfrom
dgant:codex/chokepoint-identity-upstream

Conversation

@dgant

@dgant dgant commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Distinct BWEM chokepoints connecting the same two areas currently compare and hash as equal.

Discovered on Katrina, where one of the main bases appears to have no walkable choke leading out of it.

Comment thread src/test/java/bwapi/BWEMTest.java Resolved
Comment thread src/main/java/bwem/ChokePoint.java Resolved
Comment thread src/test/java/bwapi/BWEMTest.java Resolved
@dgant dgant changed the title BWEM Bugfix: Different chokes receive equal hashcodes BWEM Bugfix: Different chokes considered equal Nov 10, 2026
@JasperGeurtz
JasperGeurtz self-requested a review November 11, 2026 20:18

@JasperGeurtz JasperGeurtz left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@JasperGeurtz
JasperGeurtz merged commit c0512d8 into JavaBWAPI:develop Nov 11, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants